Repository navigation
Conversation
The package owns which queued turn is drawn, when it follows the reader to the end of the thread, and where the composer's queued actions attach. The app keeps who sent it, their icon and how the text reads, passed in as props.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The spec already drives the queued turn through its reveal and handoff in the browser; the tag lets the gate record it as evidence for the row the package now draws.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The queued follow-up row, the turn the server is about to admit after a completed response, is drawn by an app-side component that owns its own reveal bookkeeping, follow-scroll and composer-actions anchor. A themed consumer of
@librechat/chattherefore cannot show a queued turn without copying that logic.This moves the logic into a package
PendingTurn: which queued turn is drawn (only after the response it follows, and not once the thread has a successor), when it follows a reader resting at the end of the thread into view, and where the composer's queued actions attach. The app keeps a thin adapter that supplies who sent it, their icon and how the text reads (markdown or plain), passed in as props. The spec moved with the logic into the package; the app keeps an adapter spec. No visible change.Type of change
Testing
Tested environments/configuration: jsdom specs; browser verification of the queued-turn scenarios is run through the gate once the PR is open.
Automated tests:
packages/chat: full jest, 185 suites and 2826 tests pass, including the portedPendingTurnspec (five cases: draws after the response it follows, nothing without a reveal, nothing on a different tail, leaves when the reveal ends, hides on a real successor);npm run typecheckclean.client:tsc --noEmitclean;src/components/Chatspecs pass except the existingAskUserQuestion(s)failures that also fail on dev and are owned elsewhere.packages/client: 1163 tests pass.